Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct prerequisite rules #35

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

tariqkurd-repo
Copy link
Collaborator

Addresses #29

@sorear
Copy link
Contributor

sorear commented Jan 24, 2024

Zcd or D doesn't make much sense, Zcd implies D?

@tariqkurd-repo
Copy link
Collaborator Author

Zcd or D doesn't make much sense, Zcd implies D?

You can specify either. Zcd implies D, and D will infer C.FSDSP etc. if C or Zca are included even if Zcd isn't included.
It's weird but that's how it is.

@tariqkurd-repo tariqkurd-repo merged commit 1c969c6 into riscv:main Jan 24, 2024
2 checks passed
@jrtc27
Copy link
Collaborator

jrtc27 commented Jan 24, 2024

Zcd or D doesn't make much sense, Zcd implies D?

You can specify either. Zcd implies D, and D will infer C.FSDSP etc. if C or Zca are included even if Zcd isn't included. It's weird but that's how it is.

Which is sorear's point: that Zcd || D is entirely equivalent to D as a boolean expression given Zcd implies D. I think what you want here to make it not weird (other than due to the retroactive splitting of C) is Zcd or DC.

I don't think you're right that DZca infers Zcd though? LLVM doesn't do that, and I don't see why it would. Isn't the whole point of Zca to let you not have things like Zcd?

@tariqkurd-repo
Copy link
Collaborator Author

tariqkurd-repo commented Jan 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants